attr_newbie is removed when item is placed in the vendor box

attr_newbie is removed when item is placed in the vendor box - Printable Version

+- SphereCommunity (https://forum.spherecommunity.net)
+-- Forum: Sphere 0.56d (/Forum-Sphere-0-56d)
+--- Forum: General Help (/Forum-General-Help)
+--- Thread: attr_newbie is removed when item is placed in the vendor box (/Thread-attr-newbie-is-removed-when-item-is-placed-in-the-vendor-box)

attr_newbie is removed when item is placed in the vendor box - Wap - 02-19-2013 12:51 AM

Ben Wrote:This is not a bug, it's a feature. It was purposly done this way.

I don't want to flood in the bugtracker, but... what is the reason of this "feature"?

Because for scripter it is uncomfortable, is needed one-three lines, to add this fix manually, if scripter needed it

Code:

[TYPEDEF t_eq_vendor_box]

ON=@DropON_Self

ARGO.ATTR=<ARGO.ATTR>&~attr_newbie

and, it seems, no normal way to disable this core-issue.
I can think out only one way to fix this(with allowing selling newbie items) - adding to all newbie items control tag, and re-add attr_newbie, while item is bought. But it is +1 fix "through ass"...

RE: attr_newbie is removed when item is placed in the vendor box - Ultima One - 02-19-2013 01:54 AM

This is one thing that has disrupted my peace and quiet many times before, when a scribe sells full spellbooks on his shop, but forgets to place them in a bag before putting them in the vendor box.. I spend half my day fixing spellbooks that players buy from player vendors, who have died and lost them >_>

Does your fix work then Wap?

RE: attr_newbie is removed when item is placed in the vendor box - Mordaunt - 02-19-2013 02:23 AM

There shouldn't be that many items newbified going in and out of vendor boxes really.
Obviously a spell book is the main exception to the rule, if that is the main concern why not just add an event to spell books under the @dclick trigger to check for the newbie flag and add it if it is needed.
The event shouldn't fire that much anyway as a new owner would likely only dclick the spell book a couple of times, likely setting up their icon shortcuts once they obtain the book.

RE: attr_newbie is removed when item is placed in the vendor box - Wap - 02-19-2013 02:44 AM

(02-19-2013 01:54 AM)charm Wrote: Does your fix work then Wap?

+ FORCONT if needed.

(02-19-2013 02:23 AM)Mordaunt Wrote: There shouldn't be that many items newbified going in and out of vendor boxes really.
Obviously a spell book is the main exception to the rule, if that is the main concern why not just add an event to spell books under the @dclick trigger to check for the newbie flag and add it if it is needed.
The event shouldn't fire that much anyway as a new owner would likely only dclick the spell book a couple of times, likely setting up their icon shortcuts once they obtain the book.

For items, which are always newbie, anti-fix can be +- normal:
ON=@ItemBuy
IF (<def0.alwaysnewbie_<argo.baseid>>)
...+attr_newbie or timerf if there are any problems with adding attr_newbie on @ItemBuy
But for items, that can be newbie or not...

But OK, if you think that in-core newbie status removing from sold newbie items is actual and nessessary, I can add stupid control tag for newbie items.

Also one interesting issue, attr_blessed, which I tried as alternative to attr_newbie, is removing on world save. But may be it also is purposly done this way, I don't know. Smile

RE: attr_newbie is removed when item is placed in the vendor box - Ben - 02-19-2013 05:12 AM

I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.

RE: attr_newbie is removed when item is placed in the vendor box - Wap - 02-19-2013 05:24 AM

(02-19-2013 05:12 AM)Ben Wrote: I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.

Thank you! Smile

RE: attr_newbie is removed when item is placed in the vendor box - Barnabus - 02-20-2013 12:40 AM

Did Anyone ever make a Fix for the Vendor Box ?

So that we can move in items via code, without them vanishing randomly on some save ?

RE: attr_newbie is removed when item is placed in the vendor box - Ultima One - 02-27-2013 07:57 PM

(02-19-2013 05:12 AM)Ben Wrote: I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.

Doesn't work. To put it simply.

I enabled this the other day, set to 1, put a spellbook in a vendor, bought it, ATTR=00. Was 04 before it went in.

RE: attr_newbie is removed when item is placed in the vendor box - Ben - 02-28-2013 10:15 AM

looks like I did it in reverse Smile

I'll have to fix that, it should work if set to 0 right now though... oops

RE: attr_newbie is removed when item is placed in the vendor box - Ultima One - 02-28-2013 08:22 PM

Ok, will switch it to 0 for now ;D