Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
attr_newbie is removed when item is placed in the vendor box
Author Message
Wap
Journeyman
*

Posts: 138
Likes Given: 6
Likes Received: 7 in 6 posts
Joined: Mar 2012
Reputation: 3

UORPG.net

Post: #1
attr_newbie is removed when item is placed in the vendor box
Ben Wrote:This is not a bug, it's a feature. It was purposly done this way.

I don't want to flood in the bugtracker, but... what is the reason of this "feature"?

Because for scripter it is uncomfortable, is needed one-three lines, to add this fix manually, if scripter needed it
Code:
[TYPEDEF t_eq_vendor_box]
ON=@DropON_Self
ARGO.ATTR=<ARGO.ATTR>&~attr_newbie
and, it seems, no normal way to disable this core-issue.
I can think out only one way to fix this(with allowing selling newbie items) - adding to all newbie items control tag, and re-add attr_newbie, while item is bought. But it is +1 fix "through ass"...
02-19-2013 12:51 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Ultima One
Journeyman
*

Posts: 238
Likes Given: 7
Likes Received: 10 in 6 posts
Joined: Jan 2013
Reputation: 6

Ultima One

Post: #2
RE: attr_newbie is removed when item is placed in the vendor box
This is one thing that has disrupted my peace and quiet many times before, when a scribe sells full spellbooks on his shop, but forgets to place them in a bag before putting them in the vendor box.. I spend half my day fixing spellbooks that players buy from player vendors, who have died and lost them >_>

Does your fix work then Wap?

ULTIMA ONE
The modern, sphere powered Ultima Online server
(This post was last modified: 02-19-2013 01:55 AM by Ultima One.)
02-19-2013 01:54 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Mordaunt
Super Moderator
****

Posts: 1,237
Likes Given: 26
Likes Received: 55 in 43 posts
Joined: Mar 2012
Reputation: 35



Post: #3
RE: attr_newbie is removed when item is placed in the vendor box
There shouldn't be that many items newbified going in and out of vendor boxes really.
Obviously a spell book is the main exception to the rule, if that is the main concern why not just add an event to spell books under the @dclick trigger to check for the newbie flag and add it if it is needed.
The event shouldn't fire that much anyway as a new owner would likely only dclick the spell book a couple of times, likely setting up their icon shortcuts once they obtain the book.

[Image: 2nis46r.jpg]
02-19-2013 02:23 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Wap
Journeyman
*

Posts: 138
Likes Given: 6
Likes Received: 7 in 6 posts
Joined: Mar 2012
Reputation: 3

UORPG.net

Post: #4
RE: attr_newbie is removed when item is placed in the vendor box
(02-19-2013 01:54 AM)charm Wrote:  Does your fix work then Wap?
+ FORCONT if needed.

(02-19-2013 02:23 AM)Mordaunt Wrote:  There shouldn't be that many items newbified going in and out of vendor boxes really.
Obviously a spell book is the main exception to the rule, if that is the main concern why not just add an event to spell books under the @dclick trigger to check for the newbie flag and add it if it is needed.
The event shouldn't fire that much anyway as a new owner would likely only dclick the spell book a couple of times, likely setting up their icon shortcuts once they obtain the book.
For items, which are always newbie, anti-fix can be +- normal:
ON=@ItemBuy
IF (<def0.alwaysnewbie_<argo.baseid>>)
...+attr_newbie or timerf if there are any problems with adding attr_newbie on @ItemBuy
But for items, that can be newbie or not...

But OK, if you think that in-core newbie status removing from sold newbie items is actual and nessessary, I can add stupid control tag for newbie items.

Also one interesting issue, attr_blessed, which I tried as alternative to attr_newbie, is removing on world save. But may be it also is purposly done this way, I don't know. Smile
(This post was last modified: 02-19-2013 03:28 AM by Wap.)
02-19-2013 02:44 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Ben
Sphere Developer
*****

Posts: 612
Likes Given: 2
Likes Received: 123 in 70 posts
Joined: Mar 2010
Reputation: 18

SphereCommunity

Post: #5
RE: attr_newbie is removed when item is placed in the vendor box
I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.

AxisII's current version: 2.0.4j
AxisII SourceCode on Github
AxisII up to date changelog
02-19-2013 05:12 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Wap
Journeyman
*

Posts: 138
Likes Given: 6
Likes Received: 7 in 6 posts
Joined: Mar 2012
Reputation: 3

UORPG.net

Post: #6
RE: attr_newbie is removed when item is placed in the vendor box
(02-19-2013 05:12 AM)Ben Wrote:  I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.
Thank you! Smile
02-19-2013 05:24 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Barnabus
Journeyman
*

Posts: 124
Likes Given: 0
Likes Received: 3 in 2 posts
Joined: Apr 2012
Reputation: 1



Post: #7
RE: attr_newbie is removed when item is placed in the vendor box
Did Anyone ever make a Fix for the Vendor Box ?

So that we can move in items via code, without them vanishing randomly on some save ?
02-20-2013 12:40 AM
Find all posts by this user Like Post Quote this message in a reply
Ultima One
Journeyman
*

Posts: 238
Likes Given: 7
Likes Received: 10 in 6 posts
Joined: Jan 2013
Reputation: 6

Ultima One

Post: #8
RE: attr_newbie is removed when item is placed in the vendor box
(02-19-2013 05:12 AM)Ben Wrote:  I have an option... I'm adding a sphere.ini option ALLOWNEWBTRANFER. If set to 1, attr_newbie will not be removed.

Doesn't work. To put it simply.

I enabled this the other day, set to 1, put a spellbook in a vendor, bought it, ATTR=00. Was 04 before it went in.

ULTIMA ONE
The modern, sphere powered Ultima Online server
(This post was last modified: 02-27-2013 08:01 PM by Ultima One.)
02-27-2013 07:57 PM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Ben
Sphere Developer
*****

Posts: 612
Likes Given: 2
Likes Received: 123 in 70 posts
Joined: Mar 2010
Reputation: 18

SphereCommunity

Post: #9
RE: attr_newbie is removed when item is placed in the vendor box
looks like I did it in reverse Smile
I'll have to fix that, it should work if set to 0 right now though... oops

AxisII's current version: 2.0.4j
AxisII SourceCode on Github
AxisII up to date changelog
02-28-2013 10:15 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Ultima One
Journeyman
*

Posts: 238
Likes Given: 7
Likes Received: 10 in 6 posts
Joined: Jan 2013
Reputation: 6

Ultima One

Post: #10
RE: attr_newbie is removed when item is placed in the vendor box
Ok, will switch it to 0 for now ;D

ULTIMA ONE
The modern, sphere powered Ultima Online server
02-28-2013 08:22 PM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)