Threaded Mode | Linear Mode

Extreme · 09-30-2014 03:56 AM

(09-30-2014 03:50 AM)Coruja Wrote: try update your fishing skill on sphere_skills.scp based on latest scripts pack release, it's working fine here

also make sure that you're using this new script code on a sphere nightly >= 19 july 2014. This fishing change was implemented on this build when this skill got softcoded. If you try to use the softcoded fishing skill on a previous sphere build, or try to use a newest sphere build without the softcoded fishing skill, you will get some problems

His code is okay, I tested here... If he say it's not working there, just use an older version... I'm using the #2010 and everything is fine for me. It's not needed if the current build is perfect for you.

Skul · 09-30-2014 04:32 AM

Hmm, everything works fine but fishing. I will try and test it out later, right now I am a bit busy (day off), back to work tomorrow for 6 days.

Rizz · 09-30-2014 05:05 AM

I use r2036 and this code:

Code:

[SKILL 18]

DEFNAME=Skill_Fishing

KEY=Fishing

TITLE=Fisher%s

FLAGS=SKF_GATHER

RANGE=6

PROMPT_MSG=What water do you want to fish in?

DELAY=8.0

STAT_STR=0

STAT_INT=0

STAT_DEX=0

BONUS_STR=10

BONUS_DEX=90

BONUS_INT=0

BONUS_STATS=25

ADV_RATE=5.0,50.0,350.0

VALUES=1,30,200

ON=@PreStart

    // IF (<SRC.FINDLAYER.2.USESCUR>< 1)

        // SRC.SYSMESSAGE The tool is out of charges.

        // return 1

    // ENDIF

ON=@Start

    ANIM 11

    SERV.NEWITEM i_memory_fishing_splash

    NEW.LINK=<UID>

    NEW.P=<ACT.P>

ON=@Success

    ACTARG2=0        // 1 will pack the resource, 0 place it on the ground.

    sound 05a4

    //SRC.FINDLAYER.2.USESCUR --

ON=@Fail

    SRC.SYSMESSAGE You fish a while, but fail to catch anything.

ON=@Abort

    SRC.SYSMESSAGE You pull your line back in and stop fishing.

ON=@Stroke

    IF (<SRC.FINDLAYER.layer_horse>)

        SRC.SYSMESSAGE You can't fish while riding!

        return 1

    ENDIF

[ITEMDEF i_memory_fishing_splash]

ID=i_memory

ON=@Create

ATTR=attr_move_never|attr_decay

TIMERD=15

IF (<TIMERD> > <SERV.SKILL.FISHING.DELAY>)    // We don't want to fire the splash after the fish success so a check for skill's delay is needed.

 TIMERD=<eval <SERV.SKILL.FISHING.DELAY>/2>

ENDIF

ON=@Timer

IF (<LINK.ACTION> == skill_fishing)        // Check out if cont is still fishing, otherwise we don't want the effect.

 EFFECT 2,0352D,4,16

 SOUND 0364

ENDIF

everything is with GM OFF but players are experiencing some problems: 9 times on 10 they cannot finish the action.
What should i do?

UPDATE: fishing is working for me now but player are experiencing this "you have not line of sight". Never had this check before.

Rizz · 10-02-2014 07:35 PM

UPDATE: anything is changed but now seems fishing has some problems, it aborts the action everytime

***Coruja*** · 10-03-2014 08:37 AM

Here it works fine as always, and using latest nightly it works fine too. Check if you're using some player event with trigger like @SkillStart, @SkillSelect, etc

maybe your problem is on this external event, not on fishing skill. Also make sure that your char is alive (hits > 0 and doesnt have statf_dead flag) because "dead" chars cant use skills

Threaded Mode \| Linear Mode fishing latest nightly
Author	Message