SphereCommunity
fishing latest nightly - Printable Version

+- SphereCommunity (https://forum.spherecommunity.net)
+-- Forum: Sphere 0.56d (/Forum-Sphere-0-56d)
+--- Forum: General Help (/Forum-General-Help)
+--- Thread: fishing latest nightly (/Thread-fishing-latest-nightly)

Pages: 1 2


fishing latest nightly - Skul - 09-30-2014 01:40 AM

The fishing skill seems to be broken on the latest nightly release. As a GM I can fish without problems but my players are having problems, the skills seems to @abort when it is suppose to @success. Can anyone confirm?


RE: fishing latest nightly - Rizz - 09-30-2014 02:07 AM

I found this on the latest script pack:

PHP Code:
[SKILL 18]
DEFNAME=Skill_Fishing
KEY
=Fishing
TITLE
=Fisher%s
FLAGS
=SKF_GATHER
PROMPT_MSG
=What water do you want to fish in?
DELAY=8.0
RANGE
=4
STAT_STR
=40
STAT_INT
=30
STAT_DEX
=40
BONUS_STR
=10
BONUS_DEX
=90
BONUS_INT
=0
BONUS_STATS
=25
ADV_RATE
=2.5,50.0,200.0
VALUES
=1,30,200

ON
=@PreStart
    
IF (<SRC.FINDLAYER.layer_horse>)
        
SRC.SYSMESSAGE You can't fish while riding!
        return 1
    ENDIF
    IF (<SRC.FINDLAYER.2.USESCUR>< 1)
        SRC.SYSMESSAGE The tool is out of charges.
        return 1
    ENDIF

ON=@Start
    ANIM 12
    SERV.NEWITEM i_memory_fishing_splash
    NEW.LINK=<UID>
    NEW.P=<ACT.P>

ON=@Success
    ACTARG2=1        // 1 will pack the resource, 0 place it on the ground.
    SRC.FINDLAYER.2.USESCUR --

ON=@Fail
    SRC.SYSMESSAGE You fish a while, but fail to catch anything.

ON=@Abort
    SRC.SYSMESSAGE You pull your line back in and stop fishing.

ON=@Stroke
    IF (<SRC.FINDLAYER.layer_horse>)
        SRC.SYSMESSAGE You can'
t fish while riding!
        return 
1
    
ENDIF
    
// Damage for Fishing Poles was never active, I add it here anyway.
    //IF ( <SERV.EXPERIMENTAL>&00002000)        // EF_DamageTools
    //    IF (<SRC.FINDLAYER.2.HITS> > 0)
    //        SRC.FINDLAYER.2.DAMAGE <eval <maxhits>*2>,DAM_PHYSICAL,<SRC>
    //    ELSE
    //        SRC.FINDLAYER.2.DESTROY
    //    ENDIF
    //ENDIF

[ITEMDEF i_memory_fishing_splash]
ID=i_memory

ON
=@Create
ATTR
=attr_move_never|attr_decay
TIMERD
=15
IF (<TIMERD> > <SERV.SKILL.FISHING.DELAY>)    // We don't want to fire the splash after the fish success so a check for skill's delay is needed.
 
TIMERD=<eval <SERV.SKILL.FISHING.DELAY>/2>
ENDIF

ON=@Timer
IF (<LINK.ACTION> == skill_fishing)        // Check out if cont is still fishing, otherwise we don't want the effect.
 
EFFECT 2,0352D,4,16
 SOUND 0364
ENDIF 

I tried with .gm off and seems working... i didn't try with a normal pg...


RE: fishing latest nightly - Skul - 09-30-2014 02:09 AM

I found it works for plevel > 1, as a player plevel=1 it seems to never @success. However it does work sometimes but then stops to work completely. I reverted to an older version of sphereserver and now I'm having no problems.


RE: fishing latest nightly - Rizz - 09-30-2014 02:45 AM

Which version?


RE: fishing latest nightly - Skul - 09-30-2014 02:50 AM

August 4th and later, it's been broken since I've tried.

I reverted to a copy from 2013.


RE: fishing latest nightly - Extreme - 09-30-2014 02:52 AM

(09-30-2014 02:50 AM)Skul Wrote:  August 4th and later, it's been broken since I've tried.

I reverted to a copy from 2013.

Please paste here your Fishing SKILL section please.


RE: fishing latest nightly - Skul - 09-30-2014 02:55 AM

Code:
[SKILL 18]
DEFNAME=Skill_Fishing
KEY=Fishing
TITLE=Fisher
PROMPT_MSG=What water do you want to fish in?
DELAY=2.5
STAT_STR=0
STAT_INT=0
STAT_DEX=0
BONUS_STR=0
BONUS_DEX=0
BONUS_INT=0
BONUS_STATS=0
ADV_RATE=0.1,50.0,150.0
VALUES=1,30,200
RANGE=6
FLAGS=SKF_GATHER|SKF_NOMINDIST

ON=@START
LOCAL.CRAFTSTROKECNT=1
ANIM=11
SOUND=39
SERV.NEWITEM=0352d
NEW.ATTR=attr_move_never|attr_decay
NEW.P=<TARGP>
NEW.TIMER=2

ON=@TRY
IF ( <FLAGS> & statf_polymorph )
    SYSMESSAGE=You can not do that in your state.
    RETURN 1
ENDIF

ON=@SUCCESS
//lengthy code

ON=@ABORT
IF !(<TAG0.FISHINGFAIL>)
    TIMERF 1, f_fishing_abort
ENDIF
CTAG.TARGP=
CTAG.RESOURCE=
TAG.ACTITEM=
TAG.FIGHINGFAIL=

ON=@FAIL
IF !(<TAG0.FISHINGFAIL>)
    MESSAGE You find nothing useful.
ENDIF
CTAG.TARGP=
CTAG.RESOURCE=
TAG.ACTITEM=
TAG.FIGHINGFAIL=

[FUNCTION f_fishing_abort]
IF (<SERV.SKILL.<ACTION>.KEY>==fishing)
    MESSAGE You reel the line in and cast out again.
ELSE
    MESSAGE You reel the line in.
ENDIF



RE: fishing latest nightly - Extreme - 09-30-2014 03:33 AM

Okay, my build is working fine.
https://mega.co.nz/#!vMAHnQpa!dfYH-3RyHFPU1OlxvPOIs0T2EdLNzY31p5LkYhgGcBE


RE: fishing latest nightly - darksun84 - 09-30-2014 03:35 AM

fishing works fine for me


RE: fishing latest nightly - Coruja - 09-30-2014 03:50 AM

try update your fishing skill on sphere_skills.scp based on latest scripts pack release, it's working fine here

also make sure that you're using this new script code on a sphere nightly >= 19 july 2014. This fishing change was implemented on this build when this skill got softcoded. If you try to use the softcoded fishing skill on a previous sphere build, or try to use a newest sphere build without the softcoded fishing skill, you will get some problems