Post: #1

Hi all, I am trying to get the quest script system working on my shard, and I am having some odd parsing problems after adding one of the quests to the quest pc.

My system is running V0.56b Pre-Release Found at: http://prerelease.sphere.torfo.org/

I am using the latest nightly script build for V0.56c

This is currently a self-play testing/learning shard, so I'm not too worried about the issues with the TYPEDEF etc changes, but this could be why things are failing...

Anyway the script in question is the Quest system found here:
http://scripts.sphere.torfo.org/ - latest version.

When I setup the npc quester, and add one of the included quests that use the Cliloc the system acts perfect. But when I try to add one of the quests that start at 500 in the quest list, I get a strange bunch of errors on the server console.

To make things easier to understand I have included what the contents of each part of the scripts I am using, not the entire script, just the part that is in question.

From sphere_quest_quests.scp


After adding the 2 quests to the npc, using:


I get no errors, all is fine. But when I click on the NPC to see the quests I get only one quest in the window, Quest 1, and Quest 500 has only the arrow to click to the next page. On my console I get this:


The section in question from sphere_quest_dialogs.scp is here:


So, I think the problem is within this section at least for the title portion of the quest. Line 365, looking farther down the script I see similar code.

So this is why I'm thinking is must be some sort of parsing problem, as the cliloc quests work fine, but the ones using plain text fail.

Any help on this would be awesome! I'm learning a lot about the scripting here, but I just can't get a handle on this advanced stuff.

Thanks for taking a look
PT

Post: #2

If you look at it, first checks for any string inside _namelocalized, its ok if you have inside it any number or value that sphere knows [itemdef xxx],[chardef ], etc... but with text it can't be checked this way... so the _namelocalized let it for using with clilocs only and change it to def._name as it is using _name instead of _namelocalized if the second is empty. Try this:

Post: #3

To that I am afraid I must draw your attention to the actual script file and the "500" series quests:


I know this way at least used to work because looking at these quests, as the conversation went in IRC the other day, I think I actually wrote some of them.
Do these ones still work?
If so try something stupid just to test (I can't I don't run this script or a pack that readily supports it) comment out the custom text on each of the lines and add in a little test text of your own. See if it shows up.

Post: #4

In numerous places, the code looks like this:


Notice how it first looks if QUEST_516_NAMELOCALIZED exists, and if it does, it uses that... otherwise it uses QUEST_516_NAME ... so Xun's solution would likely work.

But if QUEST_516_NAMELOCALIZED exists... there is also an ehnum function that decides whether to use a xmfhtmlgumpcolor (which requires a cliloc number) or the dhtmlgump (which can use text.) So Mordaunt's claim that these used to work may also be true - which probably means that ehnum function (not shown) might be doing unexpected things.

Post: #5

Okay this is starting to make a bit more sense. I will have to test stuff tonight and report back. Thanks for the info!!

Post: #6

So I edited the sphere_quest_quests.scp, changing the quest info for quest 500, removing the LOCALIZED info.


And the quest now shows up. The errors on the console continue I'm afraid.

I found the EHNUM Function:


sounds like in the most simple terms of I can safely state, the script when building the dialog, it will look at the script definitions within the sphere_quest_quests.scp file, find out if the quest is based upon a cliloc type or a string type, then it will create the proper dialog system to display. It uses the ehnum function to do the test to see if its cliloc or not.

Line 365

is the 1st spot where I get the error, so I wonder if there is a better way to do this.

Anyway, still mucking around with this.

PT

Post: #7

For that last problem the fix would be change the check for this one:


You should check this way every time you have any string saved in defs,tags,etc because Sphere try to 'reads' what you have inside and, in this case, what the def holds are just unknown strings for sphere, if you had there i_gold or something already defined it wouldn't give error, but it's not the case.

Note: changing this line allows you to use normal text by both ways, using _text or _textlocalized