Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
PetSlots experimental feature
Author Message
Extreme
Grandmaster Poster
***

Posts: 1,149
Likes Given: 220
Likes Received: 86 in 76 posts
Joined: May 2012
Reputation: 20

SphereCommunity

Post: #11
RE: PetSlots experimental feature
Just found a bug when summoning Blade Spirit and Vortex, they looks like not pet, but when created, they increase the slots on caster, but they don't decrease when die or whatever.

I made this small fix, hope you can find the way to fix this on source.

PHP Code:
ON=@DEATH
IF (<BASEID> == C_BLADE_SPIRIT) || (<BASEID> == C_VORTEX)
 
REF1 <FINDID.I_RUNE_SUMMON_CREATURE.LINK>
 IF (<
REF1>)
  
REF1.CURFOLLOWER -= <MAX 1,<FOLLOWERSLOTS>>
 ENDIF
ENDIF 

STEPS BEFORE CREATE A THREAD
- Check the revisions log;
- Use the search button and use the keywords of your problem;
- Check the WIKI;
- Create a thread.
11-05-2014 06:10 AM
Find all posts by this user Like Post Quote this message in a reply
Coruja
Sphere Developer
*****

Posts: 815
Likes Given: 4
Likes Received: 190 in 156 posts
Joined: Jul 2012
Reputation: 6

Dimension Shard

Post: #12
RE: PetSlots experimental feature
confirmed, sometimes the npc is not clearing the owner memory correctly on @Death

I commited this fix some minutes ago, maybe it's working fine now
11-05-2014 05:12 PM
Find all posts by this user Like Post Quote this message in a reply
[+] 2 users Like Coruja's post
alexpetro
Apprentice
*

Posts: 14
Likes Given: 0
Likes Received: 0 in 0 posts
Joined: Apr 2012
Reputation: 0



Post: #13
RE: PetSlots experimental feature
Finally! Thanks.
11-07-2014 09:28 PM
Find all posts by this user Like Post Quote this message in a reply
Extreme
Grandmaster Poster
***

Posts: 1,149
Likes Given: 220
Likes Received: 86 in 76 posts
Joined: May 2012
Reputation: 20

SphereCommunity

Post: #14
RE: PetSlots experimental feature
Hey Coruja, another bug. It happens when you have .gm

Set for example: serv.chardef.c_horse_gray.followerslots 3
Then create the c_horse_gray and mount. You will gain only 1 follower.
If you shrink, it will consume 1 follower.

I know this only happens with gms but its a bug anyway.

If you create the gray horse and shrink, then unshrink, it will give you the same 1 follower.

I don't know why this is happening because I set the followerslots on serv.chardef.. or its wrong the way to read the follower slots.

If its not clear, I can try explain again Smile

STEPS BEFORE CREATE A THREAD
- Check the revisions log;
- Use the search button and use the keywords of your problem;
- Check the WIKI;
- Create a thread.
11-30-2014 12:11 AM
Find all posts by this user Like Post Quote this message in a reply
XuN
Sphere Developer
*****

Posts: 855
Likes Given: 102
Likes Received: 161 in 121 posts
Joined: Jul 2013
Reputation: 30



Post: #15
RE: PetSlots experimental feature
Isn't it based on characters instead of chardefs? Try that using .xfollowerslots 3
11-30-2014 12:32 AM
Find all posts by this user Like Post Quote this message in a reply
Extreme
Grandmaster Poster
***

Posts: 1,149
Likes Given: 220
Likes Received: 86 in 76 posts
Joined: May 2012
Reputation: 20

SphereCommunity

Post: #16
RE: PetSlots experimental feature
Not at all..

I created the horse after using the serv.chardef.c_horse_gray.followerslots 3
So, new horses have the followerslots = 3 BUT, if you mount (gm) you gain only 1 follower.

In other way, if you create the horse and SET followerslots = 3 (even with chardef setting = 3 or 1), it works fine.

STEPS BEFORE CREATE A THREAD
- Check the revisions log;
- Use the search button and use the keywords of your problem;
- Check the WIKI;
- Create a thread.
(This post was last modified: 11-30-2014 07:05 AM by Extreme.)
11-30-2014 07:01 AM
Find all posts by this user Like Post Quote this message in a reply
Coruja
Sphere Developer
*****

Posts: 815
Likes Given: 4
Likes Received: 190 in 156 posts
Joined: Jul 2012
Reputation: 6

Dimension Shard

Post: #17
RE: PetSlots experimental feature
strangely sphere cant read global properties (like followerslots) set directly on the chardef, it will always return 0 (and the EF_PetSlots engine will change it to 1 because it's the min value)

but if followerslots is set on npc (under @Create) instead on chardef it works fine

so I think the problem is not really on EF_PetSlots engine, but on this GetDefNum() function that read these properties. I dont know if this function intended to work like this (only return values from npcs instead chardef) so I left it as it is. But I think it must be changed to return chardef properties too Tongue
12-06-2014 06:12 AM
Find all posts by this user Like Post Quote this message in a reply
Extreme
Grandmaster Poster
***

Posts: 1,149
Likes Given: 220
Likes Received: 86 in 76 posts
Joined: May 2012
Reputation: 20

SphereCommunity

Post: #18
RE: PetSlots experimental feature
But you have the system working fine, right?

If yes, can you tell us how to fix, or the system will be useless and should be disabled because you 'left it as it is'.

STEPS BEFORE CREATE A THREAD
- Check the revisions log;
- Use the search button and use the keywords of your problem;
- Check the WIKI;
- Create a thread.
12-06-2014 09:14 AM
Find all posts by this user Like Post Quote this message in a reply
Coruja
Sphere Developer
*****

Posts: 815
Likes Given: 4
Likes Received: 190 in 156 posts
Joined: Jul 2012
Reputation: 6

Dimension Shard

Post: #19
RE: PetSlots experimental feature
it perfectly works if you set followerslots=3 on npc @Create instead [CHARDEF c_npc]

because followerslots property is read by a sphere internal function GetDefNum() exclusive to read char properties (like all these variables), and this function can read properties from chars (npc already created) but not from chardefs (which are just defs, not really the npc)
12-06-2014 11:09 AM
Find all posts by this user Like Post Quote this message in a reply
Ben
Sphere Developer
*****

Posts: 605
Likes Given: 2
Likes Received: 119 in 69 posts
Joined: Mar 2010
Reputation: 18

SphereCommunity

Post: #20
RE: PetSlots experimental feature
I'm gonna have to say, it's probably not the intended behavior and there is a way to make it check the chardef also.
I'll have a look at that right now.

AxisII's current version: 2.0.4j
AxisII SourceCode on Github
AxisII up to date changelog
12-06-2014 11:19 PM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)

This forum uses Lukasz Tkacz MyBB addons.