Post: #1

I have some concerns about combat system, i activated the following flags:

so, using the OSI formula i should have for my damage:

//Tactics Damage Bonus% = Tactics /1.6 (Add 6.25% if Tactics >= 100)
//Anatomy Damage Bonus% = (Anatomy / 2) + 5
//Lumberjack Damage Bonus% = Lumberjack /5 (Add 10% if Lumberjacking >= 100)
//Strength Damage Bonus% = Strength * 0.3 (Add 5% if Strength >= 100)
//Final Damage Bonus% = Tactics Bonus + Anatomy Bonus + Lumber Bonus + Strangth Bonus + Damage Increase Items*
// Final Damage = Base Damage + (Base Damage * Final Damage Bonus%)


Now, using a char with 100.0 in all skills, and a weapon that deal 38-38 damage.

My final damage according with this formula should be 109.
But when i attack a zombie with no armor and 10 dex, the result of the this:
ON=@HIT
serv.log <ARGN1>

is a medium damage that goes from 51 to 68-70 while i should deal around 110.


why?

Post: #2

Because Sphere don´t follow OSI rules?

Sphere is not a exact copy of OSI servers, RunUo it is. You can script your combat system to be a exact copy os OSI if you want.

Post: #3

yes but, flag 080 says that the damage is calculated EXACTLY as OSI, in fact in the revision changelog we have:

Quote:05-10-2006, Nazghul
- Added: INI flag OF_OSIDamageMod (0x04)
Modifying weapon damage OSI style, according to this formulas (originally provided by ClouD_Br):
Tactics Damage Bonus% = Tactics : 1.6 (Add 6.25% if Tactics >= 100)
Anatomy Damage Bonus% = (Anatomy : 2) + 5
Lumberjack Damage Bonus% = Lumberjack : 2 (Add 10% if Lumberjacking >= 100) // besides, this is wrong, is lumberjacking :5 not :2
Strength Damage Bonus% = Strength * 0.3 (Add 5% if Strength >= 100)
Final Damage Bonus% = Tactics Bonus + Anatomy Bonus + Lumber Bonus + Strangth Bonus + Damage Increase Items*
Final Damage = Base Damage + (Base Damage * Final Damage Bonus%)
* Damage Increase is capped at 100%.

PLUS, i'm adding my Damage function calculation that should be correct (at least i double checked with http://uo.stratics.com/content/arms-armo...php#damage and it works)



I made the following try:
i tried to attack the same zombie with same stats and same armor, with and without that 080 combat flag. Damage is totally the same; no changes at all

Post: #4

i tried the new commit with osi damage fix, but...
all skills to 100.0, axe weapon (i_axe_battle_large 45-43 damage), 100 STR and osi damage active.
My damage (checked with @Hit)

and my damage with allskills 0.0

My damage with combat flag not active and allskills to 100.0


and with allskills to 0.




=///// like no difference

Post: #5

Well I found your problem...
In @Hit, Argn is the base damage only (wich includes an str or dex bonus depending on skill used)... The OSI bonus is calculated after in the @GetHit trigger.
Check in @GetHit to see the results...

I think I might have to disable the str and dex bonus in @Hit when OSI damage is enabled...

Post: #6

with flag:

without flag:


Seems to work fine now i'm gonna check the calculus soon, if there are some issue i'll post again but hopefully everything is correct!

Post: #7

I'm prety sure there are some calculation errors... since there seems to be bonus added at many different places in the code lol
I'm looking throught it right now to figure out where I would possibly need to disable some bonus when OSI damage is enabled