Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
Author Message
Sir.Nicklas
Apprentice
*

Posts: 1
Likes Given: 0
Likes Received: 0 in 0 posts
Joined: Nov 2019
Reputation: 0



Post: #1
[CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
Hey,
I don't know if this is the correct place but i want to share a Fix, which was missed after <SERV.CLIENT.x> behavior was updated. After "Page" function gained a
revised version, there is a subroutine called "[FUNCTION GMPageDelete]". While walking trough the online clients, it will now try to find the uid clients like telnet logins. It cant, of course. So there is a small fix to be added, and no forther errors will show up.

ORIGINAL:

Code:
[FUNCTION GMPageDelete]
SERV.GMPAGE.<ARGS>.DELETE
CTAG.Dialog.GMPage.Selected=

IF (<SERV.CLIENTS>)

FOR 0 <eval <SERV.CLIENTS>-1>

  REF1=<SERV.CLIENT.<LOCAL._FOR>.UID>
  IF !(<isempty <REF1.CTAG.Dialog.GMPage.Selected>>)
   IF (<REF1.CTAG0.Dialog.GMPage.Selected> > <ARGS>)
    REF1.CTAG0.Dialog.GMPage.Selected --
   ELIF (<REF1.CTAG0.Dialog.GMPage.Selected> == <ARGS>)
    REF1.SYSMESSAGE @035 GM page cleared from queue
    REF1.CTAG.Dialog.GMPage.Selected=
    REF1.SDIALOG d_gmpage_queue
   ENDIF
  ELIF (<REF1.ISDIALOGOPEN.d_gmpage_queue>)
   REF1.DIALOGCLOSE d_gmpage_queue
   REF1.SDIALOG d_gmpage_queue
  ENDIF

ENDFOR

ENDIF


FIXED:
Code:
[FUNCTION GMPageDelete]
SERV.GMPAGE.<ARGS>.DELETE
CTAG.Dialog.GMPage.Selected=

IF (<SERV.CLIENTS>)

FOR 0 <eval <SERV.CLIENTS>-1>

IF (<SERV.CLIENT.<LOCAL._FOR>>)

  REF1=<SERV.CLIENT.<LOCAL._FOR>.UID>
  IF !(<isempty <REF1.CTAG.Dialog.GMPage.Selected>>)
   IF (<REF1.CTAG0.Dialog.GMPage.Selected> > <ARGS>)
    REF1.CTAG0.Dialog.GMPage.Selected --
   ELIF (<REF1.CTAG0.Dialog.GMPage.Selected> == <ARGS>)
    REF1.SYSMESSAGE @035 GM page cleared from queue
    REF1.CTAG.Dialog.GMPage.Selected=
    REF1.SDIALOG d_gmpage_queue
   ENDIF
  ELIF (<REF1.ISDIALOGOPEN.d_gmpage_queue>)
   REF1.DIALOGCLOSE d_gmpage_queue
   REF1.SDIALOG d_gmpage_queue
  ENDIF
  
  ENDIF
  
ENDFOR

ENDIF
11-05-2019 01:09 AM
Find all posts by this user Like Post Quote this message in a reply
Jhobean
Apprentice
*

Posts: 21
Likes Given: 0
Likes Received: 0 in 0 posts
Joined: Jun 2019
Reputation: 0



Post: #2
RE: [CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
It's this file?

https://github.com/Sphereserver/Scripts/....scp#L1162

But where the correction exactly? I don't see difference. And what was the bug?
Yesterday 12:17 AM
Find all posts by this user Like Post Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)

This forum uses Lukasz Tkacz MyBB addons.