SphereCommunity / Sphere 0.56d / Script Submissions v / [CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars


Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
Author Message
Sir.Nicklas
Apprentice
*

Posts: 1
Likes Given: 0
Likes Received: 0 in 0 posts
Joined: Nov 2019
Reputation: 0



Post: #1
[CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
Hey,
I don't know if this is the correct place but i want to share a Fix, which was missed after <SERV.CLIENT.x> behavior was updated. After "Page" function gained a
revised version, there is a subroutine called "[FUNCTION GMPageDelete]". While walking trough the online clients, it will now try to find the uid clients like telnet logins. It cant, of course. So there is a small fix to be added, and no forther errors will show up.

ORIGINAL:

Code:
[FUNCTION GMPageDelete]
SERV.GMPAGE.<ARGS>.DELETE
CTAG.Dialog.GMPage.Selected=

IF (<SERV.CLIENTS>)

FOR 0 <eval <SERV.CLIENTS>-1>

  REF1=<SERV.CLIENT.<LOCAL._FOR>.UID>
  IF !(<isempty <REF1.CTAG.Dialog.GMPage.Selected>>)
   IF (<REF1.CTAG0.Dialog.GMPage.Selected> > <ARGS>)
    REF1.CTAG0.Dialog.GMPage.Selected --
   ELIF (<REF1.CTAG0.Dialog.GMPage.Selected> == <ARGS>)
    REF1.SYSMESSAGE @035 GM page cleared from queue
    REF1.CTAG.Dialog.GMPage.Selected=
    REF1.SDIALOG d_gmpage_queue
   ENDIF
  ELIF (<REF1.ISDIALOGOPEN.d_gmpage_queue>)
   REF1.DIALOGCLOSE d_gmpage_queue
   REF1.SDIALOG d_gmpage_queue
  ENDIF

ENDFOR

ENDIF


FIXED:
Code:
[FUNCTION GMPageDelete]
SERV.GMPAGE.<ARGS>.DELETE
CTAG.Dialog.GMPage.Selected=

IF (<SERV.CLIENTS>)

FOR 0 <eval <SERV.CLIENTS>-1>

IF (<SERV.CLIENT.<LOCAL._FOR>>)

  REF1=<SERV.CLIENT.<LOCAL._FOR>.UID>
  IF !(<isempty <REF1.CTAG.Dialog.GMPage.Selected>>)
   IF (<REF1.CTAG0.Dialog.GMPage.Selected> > <ARGS>)
    REF1.CTAG0.Dialog.GMPage.Selected --
   ELIF (<REF1.CTAG0.Dialog.GMPage.Selected> == <ARGS>)
    REF1.SYSMESSAGE @035 GM page cleared from queue
    REF1.CTAG.Dialog.GMPage.Selected=
    REF1.SDIALOG d_gmpage_queue
   ENDIF
  ELIF (<REF1.ISDIALOGOPEN.d_gmpage_queue>)
   REF1.DIALOGCLOSE d_gmpage_queue
   REF1.SDIALOG d_gmpage_queue
  ENDIF
  
  ENDIF
  
ENDFOR

ENDIF
11-05-2019 01:09 AM
Find all posts by this user Like Post Quote this message in a reply
Jhobean
Journeyman
*

Posts: 98
Likes Given: 11
Likes Received: 9 in 3 posts
Joined: Jun 2019
Reputation: 2



Post: #2
RE: [CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
It's this file?

https://github.com/Sphereserver/Scripts/....scp#L1162

But where the correction exactly? I don't see difference. And what was the bug?
11-12-2019 12:17 AM
Find all posts by this user Like Post Quote this message in a reply
Coruja
Sphere Developer
*****

Posts: 987
Likes Given: 5
Likes Received: 226 in 187 posts
Joined: Jul 2012
Reputation: 7

Dimension Shard
Post: #3
RE: [CORE][FIX] GMPageDelete - Missing Catch for Clients without Chars
Thx for sharing, I will merge this fix into the script pack on next update

Anyway, you can also report these bugs directly on the script pack page on github, you just need to click on "GitHub" button here on forum header and then Scripts > Issues > New issue
11-21-2019 05:59 PM
Find all posts by this user Like Post Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)

Contact Us | SphereCommunity | Return to Top | Return to Content | Lite (Archive) Mode | RSS Syndication
This forum uses Lukasz Tkacz MyBB addons.