Threaded Mode | Linear Mode

***XuN*** · 09-26-2013 03:00 AM

(09-26-2013 02:49 AM)Archaaz Wrote: Ah, thanks! Between the three of you helping me this script will end up being two lines long....

If you wanne improve it more I think you should cleanup code from SCP formula.settings and left up only what you are going to use, I mean...

Code:

[function f_combatsys_hitchance]

doswitch <def.scp.Combat_FormulasUsed>

   return <args> // SPHERE

   begin // Custom - Reference to scp.Combat_HitChance

      doswitch <def.scp.Combat_HitChance>

         return <args>

         return <qval <r100> <= <eval ((<<combat.skill.uor>> * 10) + 5000) / (((<src.<src.combat.skill.uor>> / 10) + 50) * 2)> ? 0 : -100>

         return <qval <r100> <= <f_combatsys_hitchance_aos> ? 0 : -100>

      enddo

   end

   return <qval <r100> <= <eval ((<<combat.skill.uor>> * 10) + 5000) / (((<src.<src.combat.skill.uor>> / 10) + 50) * 2)> ? 0 : -100>

   return <qval <r100> <= <f_combatsys_hitchance_aos> ? 0 : -100>

enddo

You have this and you are going to use AOS formulas? cleanup time!

Code:

[function f_combatsys_hitchance]

return <qval <r100> <= <f_combatsys_hitchance_aos> ? 0 : -100>

It will only last this part of function and you can /2 scripts size and what it's more important for you now... you get some experience in cleaning up! and also you will read up better what this scripts are doing.

And if you are going to work with SkillClasses with different damage bonus per class... it won't be a bad idea to cut up your main damage events and apply on that skillclasses with only their bonus so you can customize better.

Threaded Mode \| Linear Mode Tactics, Focus or similar script
Author	Message