The following warnings occurred:
Warning [2] Use of undefined constant SAPI_NAME - assumed 'SAPI_NAME' (this will throw an Error in a future version of PHP) - Line: 3388 - File: inc/functions.php PHP 7.4.33-nmm6 (Linux)
File Line Function
/inc/functions.php 3388 errorHandler->error
/showthread.php 116 build_archive_link
Warning [2] Use of undefined constant IN_ARCHIVE - assumed 'IN_ARCHIVE' (this will throw an Error in a future version of PHP) - Line: 3331 - File: inc/functions.php PHP 7.4.33-nmm6 (Linux)
File Line Function
/inc/functions.php 3331 errorHandler->error
/inc/functions.php 3324 build_forum_breadcrumb
/showthread.php 195 build_forum_breadcrumb
Warning [2] Use of undefined constant IN_ARCHIVE - assumed 'IN_ARCHIVE' (this will throw an Error in a future version of PHP) - Line: 3331 - File: inc/functions.php PHP 7.4.33-nmm6 (Linux)
File Line Function
/inc/functions.php 3331 errorHandler->error
/showthread.php 195 build_forum_breadcrumb






Poll: Do you object?
Dont change anything
Only eliminate the SE, AOS, LB, files
Reduce it to 2 files
[Show Results]
 
Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Default Script Pack
Author Message
RanXerox
Master
**

Posts: 550
Likes Given: 1
Likes Received: 12 in 9 posts
Joined: Dec 2010
Reputation: 19



Post: #1
Default Script Pack
I have a huge amount of items I could add to the default scriptpack... but it's going to be a nightmare to figure out what client these items came from (T2A, AOS, SE, LBR, ML, HS, etc...)

Would anyone object to me collapsing the scriptpack item files? If not... how far can I go? For example:

Currently there are 15 "building" files:

sphere_item_building_doors.scp
sphere_item_building_doors_sa.scp
sphere_item_building_fence.scp
sphere_item_building_floors.scp
sphere_item_building_floors_sa.scp
sphere_item_building_floors_se.scp
sphere_item_building_other.scp
sphere_item_building_roofs.scp
sphere_item_building_roofs_aos.scp
sphere_item_building_roofs_ml.scp
sphere_item_building_roofs_se.scp
sphere_item_building_stairs.scp
sphere_item_building_stairs_ml.scp
sphere_item_building_walls.scp
sphere_item_building_walls_se.scp

Would anyone object if I reduced that back to just these 7 files:

sphere_item_building_doors.scp
sphere_item_building_fence.scp
sphere_item_building_floors.scp
sphere_item_building_other.scp
sphere_item_building_roofs.scp
sphere_item_building_stairs.scp
sphere_item_building_walls.scp

How about if I reduced it to just 1 file:

sphere_item_building_parts.scp

Or... I could go even further:

In total, there are currently 88 files in the items directory... would anyone object if I converted it to just 2 files (one with all the base itemdefs and another with the derivative itemdef's)?
(This post was last modified: 04-18-2013 12:30 PM by RanXerox.)
04-18-2013 12:28 PM
Find all posts by this user Like Post Quote this message in a reply
amonvangrell
Banned

Posts: 337
Likes Given: 17
Likes Received: 32 in 20 posts
Joined: Aug 2012

britannia shard

Post: #2
RE: Default Script Pack
i don`t object lol, but if i understand correct those changes would make hard to organize things... wouldn`t?
04-18-2013 02:41 PM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
RanXerox
Master
**

Posts: 550
Likes Given: 1
Likes Received: 12 in 9 posts
Joined: Dec 2010
Reputation: 19



Post: #3
RE: Default Script Pack
Personally I don't think its well organized now... I would be willing to split it back up again if there is a rational way to organize it ;-)
04-18-2013 02:46 PM
Find all posts by this user Like Post Quote this message in a reply
dagger4k
Journeyman
*

Posts: 194
Likes Given: 1
Likes Received: 12 in 12 posts
Joined: Mar 2012
Reputation: 0



Post: #4
RE: Default Script Pack
I think you should put it as the 7. If you convert it to 2 it can become an issue Confused
04-18-2013 03:34 PM
Find all posts by this user Like Post Quote this message in a reply
Rattlehead
Master
**

Posts: 290
Likes Given: 3
Likes Received: 8 in 6 posts
Joined: Jun 2012
Reputation: 8



Post: #5
RE: Default Script Pack
well, for those of us that update our defaults, so we are up to date, then turn around and drop our custom files in, i see an issue, unless we go in and delete the original 15 we have, it would cause the items to get read twice.

we should really have an svn for the scp tbh

but besides that i think the 7 is the better option, as 2 will create large files hard to search thru manually, which i do alot.
04-18-2013 05:18 PM
Find all posts by this user Like Post Quote this message in a reply
Mordaunt
Super Moderator
****

Posts: 1,237
Likes Given: 26
Likes Received: 55 in 43 posts
Joined: Mar 2012
Reputation: 35



Post: #6
RE: Default Script Pack
Honestly.... my altered and custom script all load from a folder I created that loads after everything else so it wouldn't be too big an issue for me (also the fact that my server is not live).
I do agree that the script pack is a mess and to my mind the 7 file method would be better than cramming everything into one or two files.

[Image: 2nis46r.jpg]
04-18-2013 10:44 PM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
darksun84
Sir Spamalot
****

Posts: 1,687
Likes Given: 245
Likes Received: 162 in 151 posts
Joined: Mar 2012
Reputation: 35



Post: #7
RE: Default Script Pack
7 Files for mee too !
04-18-2013 11:07 PM
Find all posts by this user Like Post Quote this message in a reply
Soulless
Super Moderator
****

Posts: 335
Likes Given: 29
Likes Received: 49 in 27 posts
Joined: Jun 2012
Reputation: 12

Ye Olde Sphere

Post: #8
RE: Default Script Pack
i vote for 7 files. seems reasonable. i wouldnt mind a more organized, and up to date def script pack. i dont think ive changed much in them. i would love ot update to a more organized version though. Smile

much like how Mord has his files in a custom folder, mine are all in a custom folder that load after everything else, except resources before regions. this wouldnt affect me very much. except some changes im sure i could go through again. like removing t_wahtever from resources for itemdefs. fixing or adding values to some itemdefs. etc.

What am I working on?
(This post was last modified: 04-19-2013 05:30 AM by Soulless.)
04-19-2013 05:29 AM
Visit this user's website Find all posts by this user Like Post Quote this message in a reply
mpgram
Apprentice
*

Posts: 21
Likes Given: 0
Likes Received: 3 in 1 posts
Joined: Apr 2013
Reputation: 0



Post: #9
RE: Default Script Pack
I have to agree with the 7 files. I search through the files manually myself, and 2 files may cause my head to explode.
04-19-2013 07:37 AM
Find all posts by this user Like Post Quote this message in a reply
Extreme
Grandmaster Poster
***

Posts: 1,141
Likes Given: 217
Likes Received: 90 in 77 posts
Joined: May 2012
Reputation: 20

SphereCommunity

Post: #10
RE: Default Script Pack
Use 7 for now, then when you find a good way to split them, just do it.
And yes, we could have a svn for scripts...

STEPS BEFORE CREATE A THREAD
- Check the revisions log;
- Use the search button and use the keywords of your problem;
- Check the WIKI;
- Create a thread.
04-19-2013 10:07 AM
Find all posts by this user Like Post Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 5 Guest(s)