SphereCommunity
Crafting Skills in last Builds. - Printable Version

+- SphereCommunity (https://forum.spherecommunity.net)
+-- Forum: General Discussion (/Forum-General-Discussion)
+--- Forum: UO/Sphere Discussion (/Forum-UO-Sphere-Discussion)
+--- Thread: Crafting Skills in last Builds. (/Thread-Crafting-Skills-in-last-Builds)

Crafting Skills in last Builds. - XuN - 02-21-2014 08:48 AM

I have commited a build recently related to http://tracker.sphere.torfo.org/bugs/view.php?id=2273 that fixed some behaviour related to SKF_CRAFT skills, wich leaded to some confussion with crafting delays... i'll explain here what is happening now with crafting:

First, this is how crafting is now working:

Code:
Added: Extra local arguments to @SkillStart and @Start (skill section) triggers for crafting
  skills:
  LOCAL.CRAFTITEMDEF - the UID of defname of the item we are currently crafting. Readable/Writable.
  Accepts ONLY UIDs of ITEMDEFs, for example:
    if (<LOCAL.CRAFTITEMDEF> == <DEF.i_katana>)
        LOCAL.CRAFTITEMDEF = <DEF.i_sword_long>
    endif
  LOCAL.CRAFTSTROKECNT - amount of strokes character makes while creating the item. Each stroke
  has DELAY specified in SKILL section. Readable/Writable.
  LOCAL.CRAFTAMOUNT - amount of items that will be created. Only usable for REPLICATable items,
  otherwise will make no effect. Readable/Writable.

What does that mean? for each stroke made, the character must wait the delay asigned to that skill in its [skill ] section, so if one item needs 5 strokes and skill's delay is 2, that means it will spend 10 seconds crafting it instead of the old 2 seconds.

How to make it work like it worked 'always'? Easy, just to to each [skill ] section related to a crafting skill, or to the crafting skill you want to revert back and place this:

Code:
ON=@Start
local.CraftStrokeCnt=1

Problem solved!


Note: As result of this change an unexpected sound bug related to crafting skills showed up, i'm fixing it.

RE: Crafting Skills in last Builds. - Extreme - 02-21-2014 01:07 PM

I had some ideas, tomorrow I write them if I remember lol

RE: Crafting Skills in last Builds. - darksun84 - 02-21-2014 01:17 PM

what about the same for gathering skills Blush

RE: Crafting Skills in last Builds. - XuN - 02-21-2014 05:50 PM

Yes, the SKF_Gathering is in my TODO list, wich will be easy to add when I fix this.

RE: Crafting Skills in last Builds. - amonvangrell - 02-22-2014 06:09 AM

I am confused.... Confused

RE: Crafting Skills in last Builds. - Extreme - 02-22-2014 08:52 AM

XuN, do I need set the craftstrokecnt in all crafting skills?
If I dont, its assume 1, right?
Need something to change de stroke delay, for custom crafting stuff, like viking sword do more strokes faster, and a pickaxe less stroke but slower...

RE: Crafting Skills in last Builds. - XuN - 02-22-2014 09:24 AM

You have to set the CraftStrokeCnt in all the skills you want a different stroke amount, since each skill seems to have a random time and not a resource-based delay. If you don't, it can be up to 6 at the higher, but i'm changing it and this is what i'm doing with them:

Code:
Fixed amount of strokes to each crafting/gathering skill, they were random, now they have by default:
    -the amount of different resources needed to make the item for crafting.
    -Resource's needed skill / 120 (8 for an item with 100.0) - gatherer's skill / 333 (3 with 100 skill) - str / 50 ( 2 points with 100 str), with a result of 3 strokes for the hardest resouces to gather to a GM in the current skill with 100 str, and less for easier resources (or more advanced skill/stat).

For the Stroke's delay ... you can double the strokes amount and remove the sound in 1/2 strokes. Maybe I can take a look and add a local for this, won't be a bad addition.

RE: Crafting Skills in last Builds. - XuN - 03-04-2014 04:30 AM

Updated:

Each skill have 2 base strokes, except alchemy that have as much strokes as resources the crafted item needs.

There's no animation for more crafting skills than bowcraft and blacksmithing (were they not using any anim before?), but I added these 2 to work as always and also Local.Anim to the trigger.

RE: Crafting Skills in last Builds. - Coruja - 03-04-2014 07:45 AM

If someone want, here it is the "new" (probably changed on ML or SA) strokes/delays from OSI:
1 stroke with 1.25s for all crafting skills

I prefer these "old" values:
Alchemy: 1 stroke / 3.1s each
(sound 0242 / success: 0240) (no anim)

Blacksmith: 1~2 strokes (rand) / 1.7s each
(sound 02a) (anim 9)

Bowcraft: 1~2 strokes (rand) / 1.7s each
(sound 055) (anim 33 - wtf)

Carpentry: 1 stroke / 3.0s each
(sound 023d) (anim 9)

Cartography: 1 stroke / 3.0s each
(sound 0249) (no anim)

Cooking: 1 stroke / 1.5s each
(no sound) (no anim)

Inscription: 1 stroke / 3.0s each
(sound 0249) (no anim)

Tailoring: 1 stroke / 4.5s each
(sound 0248) (no anim)

Tinkering: 1 stroke / 3.0s each
(no sound) (no anim)

although I dont like both, the second one seems to be better