SphereCommunity
Access Violation in CChar::CanMoveWalkTo - Printable Version

+- SphereCommunity (https://forum.spherecommunity.net)
+-- Forum: Sphere 0.56d (/Forum-Sphere-0-56d)
+--- Forum: Script Help (/Forum-Script-Help)
+--- Thread: Access Violation in CChar::CanMoveWalkTo (/Thread-Access-Violation-in-CChar-CanMoveWalkTo)

Pages: 1 2 3 4

Access Violation in CChar::CanMoveWalkTo - Norlack - 02-26-2013 04:39 AM

I've enabled the flag "EF_WalkCheck" after a server crash few days ago. Unfortunately I have in heritage a shard with tons of custom scripts (many of which made by noobs that I'm fixing one by one or replacing) and I don't know where to look for exactly.

Code:
19:28:DEBUG:>>         5308     |  0 |               CWorld::OnTick | +0
19:28:DEBUG:>>         5308     |  1 |              CSector::OnTick | +0
19:28:DEBUG:>>         5308     |  2 |                CChar::OnTick | +125
19:28:DEBUG:>>         5308     |  3 |      CChar::NPC_OnTickAction | +0
19:28:DEBUG:>>         5308     |  4 |        CChar::NPC_Act_Wander | +0
19:28:DEBUG:>>         5308     |  5 |       CChar::NPC_WalkToPoint | +0
19:28:DEBUG:>>         5308     |  6 |         CChar::CanMoveWalkTo | +0 <-- exception catch point (below is guessed and could be incorrect!)
19:28:DEBUG:>>         5308     |  7 |    CChar::CheckValidMove_New | +0
19:28:DEBUG:>>         5308     |  8 |   CWorld::GetHeightPoint_New | +0
19:28:DEBUG:>>         5308     |  9 |     CItemBase::GetItemHeight | +0
19:28:DEBUG:>>         5308     | 10 | CItemBase::GetItemHeightFlags | +0
19:28:DEBUG:__ thread (5308) __ |  # | _____ function _____________ | ticks passed from previous function start ______
19:28:DEBUG:>>         5308     |  0 |               CWorld::OnTick | +0
19:28:DEBUG:>>         5308     |  1 |              CSector::OnTick | +0
19:28:DEBUG:>>         5308     |  2 |                CChar::OnTick | +125
19:28:DEBUG:>>         5308     |  4 |        CChar::NPC_Act_Wander | +0
19:28:DEBUG:>>         5308     |  5 |       CChar::NPC_WalkToPoint | +0
19:28:DEBUG:>>         5308     |  6 |         CChar::CanMoveWalkTo | +0 <-- exception catch point (below is guessed and could be incorrect!)
19:28:DEBUG:>>         5308     |  7 |    CChar::CheckValidMove_New | +0
19:28:DEBUG:>>         5308     |  8 |   CWorld::GetHeightPoint_New | +0
19:28:DEBUG:>>         5308     |  9 |     CItemBase::GetItemHeight | +0
19:28:DEBUG:>>         5308     | 10 | CItemBase::GetItemHeightFlags | +0
19:28:CRITICAL:"Access Violation" (0x127e16), in CChar::CanMoveWalkTo() #1 "Check Valid Move"

This is the occasional console-spam with the EF_WalkCheck enabled. Do you have any tips?
Thanks




Ah, I'm using 56b Nightly (april 2012), not the latest beacuse it causes some issues with our spells that I have to fix.

RE: Access Violationi n CChar::CanMoveWalkTo - Mordaunt - 02-26-2013 04:54 AM

Either

a) your using a map that is not loaded in e.g. planes 2,3,4,5

You have to uncomment them in spheretables.scp to load their scripts or

b) You have an npc that is spawning beyond the edge of the map.

In my experience at least

RE: Access Violationi n CChar::CanMoveWalkTo - Norlack - 02-26-2013 08:49 AM

well, maps are all loaded, we use them by years... and does not seems there are bad spawn locations. :\
doing some test...
- removed all existing chars
- removed all worldgembit
The error vanished.
- restored all worldgembit
The error reappeared and going to 1,1 position I've obtained this:

Code:
23:56:ERROR:(sphere_npcs_m_Elementali.scp,506)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_Elementali.scp,506)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_AnimaliMalvagi.scp,499)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_Elementali.scp,506)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_Demoni.scp,422)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_a_Selvaggi.scp,1292)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_NonMorti.scp,468)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_NonMorti.scp,900)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.
23:56:ERROR:(sphere_npcs_m_Insetti.scp,691)Point(-1,-1): trying to get a sector for point on map #0 out of bounds for this map(6144,4096). Defaulting to sector 0 of the map.

It's happening for every existing char @Create related to COLOR definition. Never seen something like this (and I've seen several oddities in the last 10+ years ^^').

RE: Access Violationi n CChar::CanMoveWalkTo - Mordaunt - 02-26-2013 09:22 AM

That's definitely a spawn point spawning off the map. I had the same issue when i had a little bad math in my spawning script.
It may be fixable if you make sure your maps are properly defined in your .ini

Are you using standard UO maps? ML expansion? or something completely custom?

RE: Access Violationi n CChar::CanMoveWalkTo - Norlack - 02-26-2013 09:28 AM

ML expansion and UO maps customized (but not in size), and the chars at issue use the standard t_spawn_char.

RE: Access Violationi n CChar::CanMoveWalkTo - Mordaunt - 02-26-2013 09:52 AM

The issue seems to occur with gembits placed around the edge of the map where the distance set on the gembit (MOREP= <min time> <max time> <distance>) is greater than the distance to the edge of the map.

I'd suggest going and taking a look at a couple of these gembits and see what their distance is set to compared to their distance from the map edge.

RE: Access Violationi n CChar::CanMoveWalkTo - Norlack - 02-26-2013 10:18 AM

already tried, there were just two spawns with distance beyond the edge of the map.


Code:
FORINSTANCES i_worldgem_bit
    IF ( <EVAL <P.X>-<MOREZ>> < 1 ) || ( <EVAL <P.X>+<MOREZ>> > 6143 ) || ( <EVAL <P.Y>-<MOREZ>> < 1 ) || ( <EVAL <P.Y>+<MOREZ>> > 4095 )
        SERV.LOG <P>
    ENDIF
ENDFOR


RE: Access Violationi n CChar::CanMoveWalkTo - Mordaunt - 02-26-2013 10:36 AM

What I am saying is.

If the distance value stored under morep on the gembit is greater than the distance the gembit is from the edge of the map, you will have the problem you are having.

I've been there, done it and own the t-shirt

RE: Access Violationi n CChar::CanMoveWalkTo - Norlack - 02-27-2013 02:42 AM

(02-26-2013 10:36 AM)Mordaunt Wrote:  If the distance value stored under morep on the gembit is greater than the distance the gembit is from the edge of the map, you will have the problem you are having.
This is exactly what I checked. There were just two spawns with those characteristics. ^^'

RE: Access Violationi n CChar::CanMoveWalkTo - Mordaunt - 02-27-2013 02:57 AM

did you remove them? which would remove the npc's also.
I have actually raised a bug ticket for this issue now, which I should probably have done when I first encountered it myself