+- SphereCommunity (https://forum.spherecommunity.net)
+-- Forum: General Discussion (/Forum-General-Discussion)
+--- Forum: News (/Forum-News)
+--- Thread: PetSlots experimental feature (/Thread-PetSlots-experimental-feature)
Pages: 1 2
RE: PetSlots experimental feature - Extreme - 11-05-2014 06:10 AM
Just found a bug when summoning Blade Spirit and Vortex, they looks like not pet, but when created, they increase the slots on caster, but they don't decrease when die or whatever.
I made this small fix, hope you can find the way to fix this on source.
PHP Code:
ON=@DEATH
IF (<BASEID> == C_BLADE_SPIRIT) || (<BASEID> == C_VORTEX)
REF1 <FINDID.I_RUNE_SUMMON_CREATURE.LINK>
IF (<REF1>)
REF1.CURFOLLOWER -= <MAX 1,<FOLLOWERSLOTS>>
ENDIF
ENDIF
RE: PetSlots experimental feature - Coruja - 11-05-2014 05:12 PM
confirmed, sometimes the npc is not clearing the owner memory correctly on @Death
I commited this fix some minutes ago, maybe it's working fine now
RE: PetSlots experimental feature - alexpetro - 11-07-2014 09:28 PM
Finally! Thanks.
RE: PetSlots experimental feature - Extreme - 11-30-2014 12:11 AM
Hey Coruja, another bug. It happens when you have .gm
Set for example: serv.chardef.c_horse_gray.followerslots 3
Then create the c_horse_gray and mount. You will gain only 1 follower.
If you shrink, it will consume 1 follower.
I know this only happens with gms but its a bug anyway.
If you create the gray horse and shrink, then unshrink, it will give you the same 1 follower.
I don't know why this is happening because I set the followerslots on serv.chardef.. or its wrong the way to read the follower slots.
If its not clear, I can try explain again
RE: PetSlots experimental feature - XuN - 11-30-2014 12:32 AM
Isn't it based on characters instead of chardefs? Try that using .xfollowerslots 3
RE: PetSlots experimental feature - Extreme - 11-30-2014 07:01 AM
Not at all..
I created the horse after using the serv.chardef.c_horse_gray.followerslots 3
So, new horses have the followerslots = 3 BUT, if you mount (gm) you gain only 1 follower.
In other way, if you create the horse and SET followerslots = 3 (even with chardef setting = 3 or 1), it works fine.
RE: PetSlots experimental feature - Coruja - 12-06-2014 06:12 AM
strangely sphere cant read global properties (like followerslots) set directly on the chardef, it will always return 0 (and the EF_PetSlots engine will change it to 1 because it's the min value)
but if followerslots is set on npc (under @Create) instead on chardef it works fine
so I think the problem is not really on EF_PetSlots engine, but on this GetDefNum() function that read these properties. I dont know if this function intended to work like this (only return values from npcs instead chardef) so I left it as it is. But I think it must be changed to return chardef properties too
RE: PetSlots experimental feature - Extreme - 12-06-2014 09:14 AM
But you have the system working fine, right?
If yes, can you tell us how to fix, or the system will be useless and should be disabled because you 'left it as it is'.
RE: PetSlots experimental feature - Coruja - 12-06-2014 11:09 AM
it perfectly works if you set followerslots=3 on npc @Create instead [CHARDEF c_npc]
because followerslots property is read by a sphere internal function GetDefNum() exclusive to read char properties (like all these variables), and this function can read properties from chars (npc already created) but not from chardefs (which are just defs, not really the npc)
RE: PetSlots experimental feature - Ben - 12-06-2014 11:19 PM
I'm gonna have to say, it's probably not the intended behavior and there is a way to make it check the chardef also.
I'll have a look at that right now.