Post: #11

nah it's just a copy/paste typo, on the real script it's the same TAG
the entire engine is working fine (sphere script + SQL commands + SQL table + php page), the server crash only occour when this huge tag appears. The engine can sync the paperdoll of all chars on the server, it crash only when try to sync this particular char with the huge tag set.

since sphere can store this huge tag without problems (this tag on example I got directly from my spherechars save file), I think the real problem is only when it try to read this huge tag

Post: #12

Results of my local tests

Sphere Console Wrote:19:42:1:'feeh' commands 'lol'=1
19:43:1:'feeh' commands 'lol'=1

The Script used to test

The SQL table and its content AFTER script execution

No crashes
Even with one or more missing columns on the SQL table, the server just spit the error saying the column didn't existed

WAMP provided MySQL server (installed on oct/2013, don't know the version)
SQLYog 8.5.5.0 to read/write/create the tables
Sphere built on (27/apr/2014).

--------------

Try logging the tag to the console, read its length, find the first 'a' character...anything that you think it will crash the server.
Try writing the tag value to a test table and not execute its content

Provide us the SQL table schema you're using or anything else that allow us to test it locally. I'm still in blinds

Post: #13

there's no problem on SQL, everything SQL-related is working perfectly fine, the problem is just the tag. I just used a SQL example because I copy/paste it from my script

but let's try another example without SQL. This will crash the server:

no dev will make a suicide loop like this on a live shard, it's just a test to simulate an exploit. Like a button that every time you press it will add a new text string to a TAG, and some noob make an macro using infinite loop and no-delay to press this button. Result: server crash

loop results:
FOR 1 = length 1
FOR 2 = length 5
FOR 3 = length 13
FOR 4 = length 29
FOR 5 = length 61
FOR 6 = length 125
FOR 7 = length 253
FOR 8 = length 509
FOR 9 = length 1021
FOR 10 = length 2045
FOR 11 = length 4093
FOR 12 = crash

if the loop value is higher but near 12 (example: 13 or 14), sphereSvr.exe just force-close with absolutely no console error. There's no error even on log files after crash.

using loop 20 it will spam some console exceptions and then crash

and using loop 500, it will start with the same error above but at some point it will turn into "Exception adding debug message on the exception." roflmao (and will crash too)

probably the crash occour when the tag length is > 4093
I tested using a similar function and it will crash the server too
if I got some luck, sometimes the console will show the log "LENGTH: 10000 / TAG: aaaaaa..." and crash, but most of times it will crash without any error

Post: #14

see... there is a HUGE difference between a tag that is 1700 or so, and one that passé the allowed limit...
Get your facts together before you complain about something.

...and this is why we get frustrated...

Post: #15

that's exactly the problem, i'm not complaining about my code, i'm alerting an exploit that could crash the entire server in seconds.
"Luckly" this happened only on my server (1 week with force-close 5x each day, no console error, many players/donators left the server) but just imagine if many of others servers start crashing like this.

I think we must do something to prevent this situation. Sure, this protection must be done on script-side, but if the script-side fail (like a bad-intentioned player using a exploit unexpected by the dev) sphere must try to protect the server too instead let it crash

Post: #16

// Limit the number of cycles the while/for loop can proceed. Setting this to
// zero disables the limitation
MaxLoopTimes=0 ( maybe it is not related with your situation, just a reminder )

Set limit then. If you dont want inifinite loop. you can actually prevent it. Instead of tagging layers you can directly insert all of them into database. Why are you dealing such things , I donot get it actually. Mysql operations are fast and realiable. No problem about crashing etc. You can achive what you are trying to without tagging layers in a efficient and easier way. Also you are saying your server crashed during 5 days. Why dont you dump profile and looked at your function behavior about how many times used etc. At the first time, you could understand where the problem is. If someone just made a macro and used same operations many times, from the profiler screen it is easy to see where the problem is. You cannot call this situation as a exploit because you let them those noobs to do such a problem. You donot need such a huge tag. You can prefer another way. But, If this is a real problem, as developers we will certainly look where the problem is. Just keep calm and try to be happy even if you are not

Post: #17

The part that I don't like is that he made us WASTE our time with an example that DID NOT replicate the problem...

Post: #18

@Coruja
I shared something similar to your paperdoll stuff months ago. The things that you are storing with tags are actually working different way in what I stated. If you want you can look at http://forum.spherecommunity.net/Thread-...erdoll-Web and develop on it as you wish. What I shared is poor example how to do. What I mean by poor is that there is no detailed script for this. This is just a structure of how to do.You do not need to tag all layers. I checked it and all players data is transferred maybe at the same time with several function call. There is no crash issue or lag issue or whatever issue you can count. Sql operations fast and can be worked as background operation as well if you just manage. What I'm doing for transferring equipped items is to insert data into database instantly without storing in SphereServer like the following ;

Post: #19

many thx to all devs, this problem was fixed on latest may 1 nightly build. I tested these same 2 functions to simulate the exploit and now both are working fine, they just show a console warning instead crash the server


@Avatar
thx for share your engine, mine is quite similar but I sync everything in real time instead sync all chars together. I have 5000 accounts on my server, and if I sync everything together it will overload sphere and SQL too.
Each account needs to sync 24 layers + 49 skills + char info (fame, karma, kills, deaths, etc). So it's a 73 loop and 3 tables to update (paperdoll layers + skills + char info)
To sync all 5000 accounts this will be a 365.000 script loop and 15.000 SQL commands to execute. So I think its better sync in real time, the sync will be constant but much more light weight. I'm using TAGs just to optimize it.
Imagine a event like this:

Quote:ON=@Equip
SQL_SyncLayer <ACT.LAYER>

ON=@Unequip
SQL_SyncLayer <ACT.LAYER>

If the player create a macro "equip weapon + unequip weapon" with infinite loop and no-delay this will overload SQL with infinite equip/unequip commands. The TAG goes here, instead execute 1 command to each equip or unequip, it will store all layers to change and then execute a single SQL command

Post: #20

The things that i shared are not sync at the same time but once the players are logging the game actually ). Anyway, It is nice to see you got over with you problem.